nuclex-shared-dotnet/Nuclex.Support
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

WeakCollection now accepts a custom EqualityComparer to be specified

Browse Source 
git-svn-id: file:///srv/devel/repo-conversion/nusu@193 d2e56fa2-650e-0410-a79f-9358c0239efd
This commit is contained in:
Markus Ewald 2010-03-30 11:02:04 +00:00
parent b8dbf8f40d
commit f0289632f6
1 changed files with 45 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
Source/Collections/WeakCollection.cs
View File

@ -107,8 +107,22 @@ namespace Nuclex.Support.Collections {
/// Internal list of weak references that are unpacking when accessed through /// Internal list of weak references that are unpacking when accessed through
/// the WeakCollection's interface. /// the WeakCollection's interface.
/// </param> /// </param>
public WeakCollection(IList<WeakReference<ItemType>> items) { public WeakCollection(IList<WeakReference<ItemType>> items) :
this(items, EqualityComparer<ItemType>.Default) { }
/// <summary>Initializes a new weak reference collection</summary>
/// <param name="items">
/// Internal list of weak references that are unpacking when accessed through
/// the WeakCollection's interface.
/// </param>
/// <param name="comparer">
/// Comparer used to identify and compare items to each other
/// </param>
public WeakCollection(
IList<WeakReference<ItemType>> items, IEqualityComparer<ItemType> comparer
) {
this.items = items; this.items = items;
this.comparer = comparer;
} }
/// <summary> /// <summary>
@ -198,8 +212,6 @@ namespace Nuclex.Support.Collections {
/// this method, if possible. /// this method, if possible.
/// </remarks> /// </remarks>
public int IndexOf(ItemType item) { public int IndexOf(ItemType item) {
EqualityComparer<ItemType> comparer = EqualityComparer<ItemType>.Default;
for(int index = 0; index < this.items.Count; ++index) { for(int index = 0; index < this.items.Count; ++index) {
ItemType itemAtIndex = this.items[index].Target; ItemType itemAtIndex = this.items[index].Target;
if((itemAtIndex == null) || (item == null)) { if((itemAtIndex == null) || (item == null)) {
@ -207,7 +219,7 @@ namespace Nuclex.Support.Collections {
return index; return index;
} }
} else { } else {
if(comparer.Equals(itemAtIndex, item)) { if(this.comparer.Equals(itemAtIndex, item)) {
return index; return index;
} }
} }
@ -243,24 +255,20 @@ namespace Nuclex.Support.Collections {
/// True if item was successfully removed from the WeakCollection; otherwise, false. /// True if item was successfully removed from the WeakCollection; otherwise, false.
/// </returns> /// </returns>
public bool Remove(ItemType item) { public bool Remove(ItemType item) {
EqualityComparer<ItemType> comparer = EqualityComparer<ItemType>.Default; for(int index = 0; index < this.items.Count; ++index) {
ItemType itemAtIndex = this.items[index].Target;
lock(this) { if((itemAtIndex == null) || (item == null)) {
for(int index = 0; index < this.items.Count; ++index) { if(ReferenceEquals(item, itemAtIndex)) {
ItemType itemAtIndex = this.items[index].Target; this.items.RemoveAt(index);
if((itemAtIndex == null) || (item == null)) { return true;
if(ReferenceEquals(item, itemAtIndex)) { }
this.items.RemoveAt(index); } else {
return true; if(this.comparer.Equals(item, itemAtIndex)) {
} this.items.RemoveAt(index);
} else { return true;
if(comparer.Equals(item, itemAtIndex)) {
this.items.RemoveAt(index);
return true;
}
} }
} }
} // lock(this) }
return false; return false;
} }
@ -303,30 +311,32 @@ namespace Nuclex.Support.Collections {
/// Removes the items that have been garbage collected from the collection /// Removes the items that have been garbage collected from the collection
/// </summary> /// </summary>
public void RemoveDeadItems() { public void RemoveDeadItems() {
lock(this) { int eliminatedItemCount = 0;
int eliminatedItemCount = 0;
// Eliminate all items that have been garbage collected by shifting // Eliminate all items that have been garbage collected by shifting
for(int index = 0; index + eliminatedItemCount < this.items.Count; ++index) { for(int index = 0; index + eliminatedItemCount < this.items.Count; ++index) {
if(!this.items[index].IsAlive) { if(!this.items[index].IsAlive) {
++eliminatedItemCount; ++eliminatedItemCount;
this.items[index] = this.items[index + eliminatedItemCount]; } else {
} this.items[index] = this.items[index + eliminatedItemCount];
++index;
} }
}
// If any garbage collected items were found, resize the collection so // If any garbage collected items were found, resize the collection so
// the space that became empty in the previous shifting process will be freed // the space that became empty in the previous shifting process will be freed
if(eliminatedItemCount > 0) { if(eliminatedItemCount > 0) {
int endIndex = this.items.Count - eliminatedItemCount; int endIndex = this.items.Count - eliminatedItemCount;
for(int index = this.items.Count - 1; index >= endIndex; --index) { for(int index = this.items.Count - 1; index >= endIndex; --index) {
this.items.RemoveAt(index); this.items.RemoveAt(index);
}
} }
} }
} }
/// <summary>Weak references to the items contained in the collection</summary> /// <summary>Weak references to the items contained in the collection</summary>
private IList<WeakReference<ItemType>> items; private IList<WeakReference<ItemType>> items;
/// <summary>Used to identify and compare items in the collection</summary>
private IEqualityComparer<ItemType> comparer;
/// <summary>Synchronization root for threaded accesses to this collection</summary> /// <summary>Synchronization root for threaded accesses to this collection</summary>
private object syncRoot; private object syncRoot;